[Bug]: QR accounts labels #9592
Labels
area-hardware
regression-RC
DEPRECATED: Please use "regresssion-RC-x.y.z" label instead
regression-RC-7.23.0
release-7.23.0
Issue or pull request that will be included in release 7.23.0
Sev3-low
A possible confusion or deception that is only hypothetical & has no known instances in the wild
team-accounts
team-hardware-wallets
type-bug
Something isn't working
Describe the bug
Observed this today when feature QA testing chore: Update @metamask/keyring-controller to v16
#9570.
93189508 and was able to observe this label difference, and I suspect that I missed this being introduced within that PR.Prior to Keyring v13, new QR accounts were added as
Keystone x
where the x reflected the index position of the Keystone address, regardless of how many accounts were present in MetaMask. Now, QR addresses are being added with the labelAccount y
where y-1 is how many other addresses are present in the wallet.Devices observed:
Expected behavior
QR addresses should be added with a reference to their index position rather than the number of other accounts present.
While we are adjusting here, it may be worth getting product feedback on whether we want to continue to name all QR addresses as
Keystone
or whether we use a more accurate label likeQR
to reflect the fact that Airgap and any other hardware wallet supporting ERC4527 could be used here.Screenshots/Recordings
Adresses in the green box were added prior to Keyring Controller v13, and the address in the red box was added after
Steps to reproduce
Error messages or log output
No response
Version
main
Build type
None
Device
Several
Operating system
iOS, Android
Additional context
Observed on main and QA build from PR 9318/9508, but used the 7.23.0 and RC regression labels as I anticipate
93189508 being included in the next RC.Severity
This could lead to user confusion and make it challenging to keep track of QR hardware addresses.
The text was updated successfully, but these errors were encountered: