-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix the issue 9560 which QR code accounts has been reappeared aftter user remove wallets
#9616
Conversation
…ter user `remove wallets`
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 3d3b465 Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested using Bitrise build on iPhone 13 using 17.4.1 RPReplay_Final1715868579.MP4 |
This PR will fix the issue #9560 which all QR code accounts have been reappeared after user decide to
remove wallets
in metamask mobile.The fix has been done in
Engine.ts
to makeqrKeyringBuilder
to reset the qr keyring properties to default value once created a newQRHardwareKeyring
.Description
Related issues
Fixes: #9560
Manual testing steps
Delete Wallet
I understand, continue
delete
Delete my wallet
Create new wallet
Screenshots/Recordings
Before
https://www.loom.com/share/c5c3d92db6da419eabf8aabbcb63afab?sid=d597eead-d642-4de1-bbbe-3476f1311728
After
TODO
Pre-merge author checklist
Pre-merge reviewer checklist