Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the issue 9560 which QR code accounts has been reappeared aftter user remove wallets #9616

Merged
merged 2 commits into from May 16, 2024

Conversation

dawnseeker8
Copy link
Contributor

@dawnseeker8 dawnseeker8 commented May 13, 2024

This PR will fix the issue #9560 which all QR code accounts have been reappeared after user decide to remove wallets in metamask mobile.

The fix has been done in Engine.ts to make qrKeyringBuilder to reset the qr keyring properties to default value once created a new QRHardwareKeyring.

Description

Related issues

Fixes: #9560

Manual testing steps

  1. Setup wallet with QR hardware accounts and using biometric auth
  2. Go to Settings>Security & Privacy
  3. Scroll all the way to the bottom and select Delete Wallet
  4. Tap I understand, continue
  5. input delete
  6. Tap Delete my wallet
  7. Tap Create new wallet
  8. Complete setup flow
  9. Tap accounts menu and all QR code accounts have been removed.
  10. re-open and authenticate again.
  11. Tap accounts menu in home page and confirm that those QR code accounts haven't been reappeared again.

Screenshots/Recordings

Before

https://www.loom.com/share/c5c3d92db6da419eabf8aabbcb63afab?sid=d597eead-d642-4de1-bbbe-3476f1311728

After

TODO

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dawnseeker8 dawnseeker8 marked this pull request as ready for review May 13, 2024 15:51
@dawnseeker8 dawnseeker8 requested a review from a team as a code owner May 13, 2024 15:51
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 14, 2024
Copy link
Contributor

github-actions bot commented May 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3d3b465
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcc92d93-814b-40ab-8c6a-230a3d6947a3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dawnseeker8 dawnseeker8 added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 15, 2024
Copy link

sonarcloud bot commented May 15, 2024

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivek-consensys vivek-consensys added the QA in Progress QA has started on the feature. label May 16, 2024
@vivek-consensys
Copy link
Contributor

Tested using Bitrise build on iPhone 13 using 17.4.1

RPReplay_Final1715868579.MP4

@vivek-consensys vivek-consensys added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels May 16, 2024
@dawnseeker8 dawnseeker8 merged commit afd4076 into main May 16, 2024
39 checks passed
@dawnseeker8 dawnseeker8 deleted the fix/9560-deleted-accounts-reappear branch May 16, 2024 15:08
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 16, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.24.0 Issue or pull request that will be included in release 7.24.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-hardware-wallets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Deleted accounts reappear
5 participants