Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test support for HW wallet support -> implementation (Ledger) #9544

Open
angelcheung22 opened this issue May 6, 2024 · 0 comments
Open
Assignees
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-hardware-wallets type-enhancement New feature or request

Comments

@angelcheung22
Copy link

Add validation for the Ledger and HW wallet support in mobile (and extension) within the E2E tests?
In the past we've discussed the potential of using software emulators (existing or custom) to mock the responses from the device as needed at the URL or library level.

We can try mock @ledgerhq/react-native-hw-transport-ble to bypass the bluetooth communication. and then we can try to see how to do it in e2e tests. the only downside is if library upgrade, we may need to change the mock again to refect the library API change.

@angelcheung22 angelcheung22 added INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-hardware-wallets type-enhancement New feature or request labels May 6, 2024
@angelcheung22 angelcheung22 changed the title Copy of E2E test support for HW wallet support -> discovery Copy of E2E test support for HW wallet support -> implementation May 6, 2024
@angelcheung22 angelcheung22 changed the title Copy of E2E test support for HW wallet support -> implementation E2E test support for HW wallet support -> implementation May 6, 2024
@angelcheung22 angelcheung22 changed the title E2E test support for HW wallet support -> implementation E2E test support for HW wallet support -> implementation (Ledger) May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-hardware-wallets type-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants