Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setTimeout for polling in PhishingController #15976

Closed
NiranjanaBinoy opened this issue Sep 26, 2022 · 2 comments
Closed

Replace setTimeout for polling in PhishingController #15976

NiranjanaBinoy opened this issue Sep 26, 2022 · 2 comments
Labels

Comments

@NiranjanaBinoy
Copy link
Contributor

NiranjanaBinoy commented Sep 26, 2022

Replace setTimeout for polling in updatePhishingLists() in PhishingController in a time window of 60 minutes.

@NiranjanaBinoy
Copy link
Contributor Author

The corresponding PR has to be created in the controller repo.

Since the chrome alarms have to be used only for the extension, we would have to configure them at the API level to differentiate extension using mv3 from mobile and extension using mv2.
Can we introduce a new optional state variable with true value to identify extension with mv3 and use chrome alarms in that case?

Something similar to MetaMask/core#861

@NiranjanaBinoy
Copy link
Contributor Author

Closing this PR as the PhishingController does not require polling anymore.
Quoting Mark's comment on the same from the channel

Mark Stacey
In some of these cases we can remove the polling altogether. We just did that for the phishing controller, for example. That can be removed from the list, as now it lazily fetches the config when it detects that it has been too long since it last checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant