Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of __esModule as an identifier #323

Open
mcmire opened this issue Oct 19, 2023 · 0 comments
Open

Allow use of __esModule as an identifier #323

mcmire opened this issue Oct 19, 2023 · 0 comments

Comments

@mcmire
Copy link
Contributor

mcmire commented Oct 19, 2023

It is common when mocking modules in Jest tests to use a property of __esModule: true:

jest.mock('@metamask/eth-sig-util', () => {
  return {
    // eslint-disable-next-line @typescript-eslint/naming-convention
    __esModule: true,
    ...jest.requireActual('@metamask/eth-sig-util'),
  };
});

We should allow this as a property name so that we don't need an ESLint override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant