Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NPM_TOKEN to publish-release workflow call #259

Merged
merged 1 commit into from Nov 17, 2022
Merged

Add NPM_TOKEN to publish-release workflow call #259

merged 1 commit into from Nov 17, 2022

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 17, 2022

Secrets in a workflow called through workflow_call require secrets to be defined explicitly: https://docs.github.com/en/actions/using-workflows/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow

@Mrtenz Mrtenz requested a review from a team as a code owner November 17, 2022 16:28
Gudahtt
Gudahtt approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit e48fb25 into main Nov 17, 2022
@Mrtenz Mrtenz deleted the mrtenz/add-npm-token branch November 17, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mrtenz @Gudahtt