Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ESLint configs #253

Merged
merged 2 commits into from Nov 14, 2022
Merged

Test ESLint configs #253

merged 2 commits into from Nov 14, 2022

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 12, 2022

Closes #229.

By running ESLint on a dummy file, we can verify that our rules are valid. This can catch errors like typos in rules, non-existent rules, etc.

I'm using Jest for testing here. This could also let us implement rule validation on a per-package basis in the future.

@Mrtenz Mrtenz requested a review from a team as a code owner November 12, 2022 10:41
@socket-security
Copy link

socket-security bot commented Nov 12, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

Ignoring: jest@29.3.1, jest-cli@29.3.1

Powered by socket.dev

@Mrtenz
Copy link
Member Author

Mrtenz commented Nov 12, 2022

@SocketSecurity ignore jest@29.3.1
@SocketSecurity ignore jest-cli@29.3.1

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit 817d7ab into main Nov 14, 2022
@Mrtenz Mrtenz deleted the mrtenz/test-eslint-configs branch November 14, 2022 14:30
@mcmire
Copy link
Contributor

mcmire commented Nov 14, 2022

@Mrtenz Just noticed this. Great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using deprecated / non-existent rules should cause CI to fail
3 participants