New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt package to latest module template standards #249
Conversation
lint-test: | ||
name: Lint and Test | ||
runs-on: ubuntu-20.04 | ||
prepare: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we run lint
for different Node.js versions, it may still be a good idea to keep the prepare workflow. Otherwise each lint
job would be overwriting the same cache (as the Node.js version is not included in the cache key with actions/setup-node
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've adapted this package to the latest module template standards. Due to the nature of this package, there are some differences between this and the module template:
I've also updated
prettier
to the version used in the module template, and addedprettier-plugin-packagejson
.