Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt package to latest module template standards #249

Merged
merged 6 commits into from Nov 11, 2022

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 11, 2022

I've adapted this package to the latest module template standards. Due to the nature of this package, there are some differences between this and the module template:

  • There are no build or test steps in the workflow, as we do not build anything and there are no tests.
  • There is no documentation generation, as we do not have any JSDoc documentation.
  • The publish workflow was adapted slightly to work without the need to build.

I've also updated prettier to the version used in the module template, and added prettier-plugin-packagejson.

.github/workflows/publish-release.yml Outdated Show resolved Hide resolved
.github/workflows/publish-release.yml Show resolved Hide resolved
.github/workflows/create-release-pr.yml Outdated Show resolved Hide resolved
lint-test:
name: Lint and Test
runs-on: ubuntu-20.04
prepare:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we run lint for different Node.js versions, it may still be a good idea to keep the prepare workflow. Otherwise each lint job would be overwriting the same cache (as the Node.js version is not included in the cache key with actions/setup-node).

@Mrtenz Mrtenz marked this pull request as ready for review November 11, 2022 15:30
@Mrtenz Mrtenz requested a review from a team as a code owner November 11, 2022 15:30
package.json Outdated Show resolved Hide resolved
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mrtenz Mrtenz merged commit 06f8532 into main Nov 11, 2022
@Mrtenz Mrtenz deleted the mrtenz/module-template branch November 11, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants