Fix lookupNetwork deadlock
#948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this part of the controller is not tested, so we'd have to backfill tests somewhat to get this adequately covered. It would also be challenging because we don't have network mocks setup yet for these tests. For this reason I'd like to skip writing tests for this change for now, due to the urgency of getting this released for the next mobile update and ahead of the monorepo branch. |
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the `net_version` callback that did not release the lock. A `try...finally` block has been introduced to ensures the lock is always released.
Gudahtt
force-pushed
the
fix-network-lookup-deadlock
branch
from
f50d3fd
to
1e8bee8
Compare
rickycodes
approved these changes
Nov 8, 2022
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the `net_version` callback that did not release the lock. A `try...finally` block has been introduced to ensures the lock is always released.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the `net_version` callback that did not release the lock. A `try...finally` block has been introduced to ensures the lock is always released.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the `net_version` callback that did not release the lock. A `try...finally` block has been introduced to ensures the lock is always released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a deadlock accidentally introduced as part of #903. That PR introduced an early exit in the
net_versioncallback that did not release the lock.Checklist