fix issue where ethQuery is not instantiated correctly when GasFeeController is constructed #936
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troller is constructed
Gudahtt
reviewed
Oct 13, 2022
Gudahtt
reviewed
Oct 13, 2022
Gudahtt
previously approved these changes
Oct 13, 2022
Gudahtt
approved these changes
Oct 13, 2022
Merged
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
…troller is constructed (#936) * fix issue where ethQuery is not instantiated correctly when GasFeeController is constructed
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…troller is constructed (#936) * fix issue where ethQuery is not instantiated correctly when GasFeeController is constructed
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…troller is constructed (#936) * fix issue where ethQuery is not instantiated correctly when GasFeeController is constructed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXED:
ethQueryis not instantiated correctly whenGasFeeControlleris constructed, which is currently causing an E2E test failure on this PR in the extension.