Prevent parallel phishing configuration updates #930
Merged
+282
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
prevent-parallel-phishing-updates
branch
from
4c14157 to
038ea1c
Compare
When a phishing configuration update is requested while an update is in-progress, we now wait for the in-progress update to finish instead of initiating another redundant update.
Gudahtt
force-pushed
the
prevent-parallel-phishing-updates
branch
from
038ea1c to
6040bf0
Compare
adonesky1
reviewed
Oct 10, 2022
adonesky1
reviewed
Oct 10, 2022
adonesky1
reviewed
Oct 10, 2022
adonesky1
reviewed
Oct 10, 2022
2 tasks
Gudahtt
commented
Oct 10, 2022
Gudahtt
added a commit
that referenced
this pull request
Oct 12, 2022
I have noticed that locally `yarn test` will succeed the first time, the will fail with a type error saying `toNeverResolve` is undefined. After running `yarn jest --clearCache`, tests will pass again once then fail again. This custom Jest matcher was added in #930. Seemingly the way the type was added is causing this problem. I'm not entirely sure what's going on here. Something about the way Jest is loading this file is making Jest confused about this type. I found that it works more reliably if the type is moved to a separate file in the `types` directory.
Gudahtt
added a commit
that referenced
this pull request
Oct 12, 2022
I have noticed that locally `yarn test` will succeed the first time, the will fail with a type error saying `toNeverResolve` is undefined. After running `yarn jest --clearCache`, tests will pass again once then fail again. This custom Jest matcher was added in #930. Seemingly the way the type was added is causing this problem. I'm not entirely sure what's going on here. Something about the way Jest is loading this file is making Jest confused about this type. I found that it works more reliably if the type is moved to a separate file in the `types` directory.
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
When a phishing configuration update is requested while an update is in-progress, we now wait for the in-progress update to finish instead of initiating another redundant update.
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
I have noticed that locally `yarn test` will succeed the first time, the will fail with a type error saying `toNeverResolve` is undefined. After running `yarn jest --clearCache`, tests will pass again once then fail again. This custom Jest matcher was added in #930. Seemingly the way the type was added is causing this problem. I'm not entirely sure what's going on here. Something about the way Jest is loading this file is making Jest confused about this type. I found that it works more reliably if the type is moved to a separate file in the `types` directory.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
When a phishing configuration update is requested while an update is in-progress, we now wait for the in-progress update to finish instead of initiating another redundant update.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
I have noticed that locally `yarn test` will succeed the first time, the will fail with a type error saying `toNeverResolve` is undefined. After running `yarn jest --clearCache`, tests will pass again once then fail again. This custom Jest matcher was added in #930. Seemingly the way the type was added is causing this problem. I'm not entirely sure what's going on here. Something about the way Jest is loading this file is making Jest confused about this type. I found that it works more reliably if the type is moved to a separate file in the `types` directory.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
When a phishing configuration update is requested while an update is in-progress, we now wait for the in-progress update to finish instead of initiating another redundant update.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
I have noticed that locally `yarn test` will succeed the first time, the will fail with a type error saying `toNeverResolve` is undefined. After running `yarn jest --clearCache`, tests will pass again once then fail again. This custom Jest matcher was added in #930. Seemingly the way the type was added is causing this problem. I'm not entirely sure what's going on here. Something about the way Jest is loading this file is making Jest confused about this type. I found that it works more reliably if the type is moved to a separate file in the `types` directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a phishing configuration update is requested while an update is in-progress, we now wait for the in-progress update to finish instead of initiating another redundant update.
FIXED:
Checklist