Skip to content

Adding new error types and exporting them from module #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 14, 2022

Adding new error type and exporting them from module.

These are need to add error handling in MetamaskController.

Verified

This commit was signed with the committer’s verified signature.
jpuri Jyoti Puri
@jpuri jpuri requested a review from rekmarks September 14, 2022 18:41
@jpuri jpuri requested a review from a team as a code owner September 14, 2022 18:41
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpuri jpuri merged commit b7d323f into main Sep 15, 2022
@jpuri jpuri deleted the error_improvements branch September 15, 2022 09:44
MajorLift pushed a commit that referenced this pull request Oct 11, 2023

Verified

This commit was signed with the committer’s verified signature.
MajorLift Jongsun Suh
MajorLift pushed a commit that referenced this pull request Oct 11, 2023

Verified

This commit was signed with the committer’s verified signature.
MajorLift Jongsun Suh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants