Exporting formatIconUrlWithProxy to format iconUrl Proxy for tokens from swaps api #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan437
previously approved these changes
Aug 12, 2022
adonesky1
reviewed
Aug 15, 2022
adonesky1
approved these changes
Aug 16, 2022
dan437
approved these changes
Aug 16, 2022
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…rom swaps api (#889) * exporting formatIconUrlWithProxy to be used in extension for the swaps iconUrl proxy * rearranging the export
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…rom swaps api (#889) * exporting formatIconUrlWithProxy to be used in extension for the swaps iconUrl proxy * rearranging the export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use
formatIconUrlWithProxyin extension for formating the token iconURL to proxy for the tokens from swap API. Since the extension is currently using a static token list for the scenario when token detection is OFF on MAINNET, we cannot use the proxy iconUrl from the dynamic token list as the default one for swap.