3.1.0 #131
Merged
3.1.0 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mcmire
reviewed
Nov 15, 2022
CHANGELOG.md
Outdated
| - Allow prerelease versions in release headers ([#130](https://github.com/MetaMask/auto-changelog/pull/130)) | ||
|
|
||
| ### Changed | ||
| - Check for `code` property when interpreting filesystem errors ([#124](https://github.com/MetaMask/auto-changelog/pull/124)) |
There was a problem hiding this comment.
Not sure if this is worth noting or not.
There was a problem hiding this comment.
Hmm. I think the only functional difference is that if a primitive type is thrown, we now re-throw it rather than crashing again when trying to check the code property. Otherwise it should be functionally identical. We were checking the code property before, just not verifying that the error was an error before checking.
I'd probably remove it or re-word it to reflect the functional impact it has, but it's not a big deal.
There was a problem hiding this comment.
Ah, that's a good point. I was leaning toward removing this; it's kind of hard to explain, and I don't think people are likely to run into this.
Gudahtt
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added