Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpc tool improvement #554

Closed
kurtcz opened this issue Aug 14, 2019 · 4 comments
Closed

mpc tool improvement #554

kurtcz opened this issue Aug 14, 2019 · 4 comments

Comments

@kurtcz
Copy link

kurtcz commented Aug 14, 2019

Make the mpc tool more useful:

  1. It should take an assembly (or a set of assemblies) rather than a csproj as an input and

  2. it should also be able to pick up classes decorated with [DataContract] and [DataMember] attributes.

That way I could create resolvers/formatters for an entire assembly which may itself contain decorated classes declared from multiple projects. It would also allow for creating resolvers/formatters without having an access to the source code. These attributes are commonly used.

@neuecc
Copy link
Member

neuecc commented Aug 16, 2019

First, the assembly base is easier to implement.
However, for several reasons, we use source code base analysis.

  • Make it possible to generate even incomplete (including errors) source code
  • Make it possible to generate directory-based files that do not have csproj such as Unity.
  • I want to avoid double maintenance

[DataContract] may be supported in option.

@kurtcz
Copy link
Author

kurtcz commented Aug 16, 2019

Thanks for your comments. On the other hand source level forces you to generate one resolver per csproj. Perhaps it could support both modes?

  • Are you saying I can just dump all files into one directory and then run the tool over that without a csproj file? Can you share an example of this please?
  • Is the DataContract supported as an option today? Which switch do I need to use? Or you would include that optionally in the future?

Thanks for your comments!

@neuecc
Copy link
Member

neuecc commented Aug 16, 2019

new version(WIP) of mpc supports that without a csproj file.
#396

DataContract support is the future.

@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants