New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to hard fork #352
Comments
Everything sounds great to keep this project ongoing - because neuecc really created a great library - but it needs support. So lets see what neuecc says. |
If it will good for evolve to .NET, I'll agree it. |
As my absolute opinion, we should not ignore Unity correspondence. |
Thanks, @neuecc. Given your continued interest, and time available coming soon, rather than a hard fork, collaborating seems more appropriate. How would you feel about granting me push permissions to your project (and perhaps admin so I can set up web hooks and get a CI/PR build validation going on your project as I have going on my fork)? If you were to do so, I'd merge changes I've made recently from my fork into your root project. Thoughts? |
Great suggestions AArnott! I will be looking forward to use and test this library and hopefully be able to contribute myself. |
Yeah that sounds great!! One of my favourite wishes would be the compatibility of the library with unity .NET Standard 2.0 ! At the moment due to the use of emit - this is sadly not possible :) But finally getting some new releases out with all the contributions would be really great. Last release was a year ago :) |
@odysoftware Let's take up this Unity discussion over here: AArnott#15. It's an interesting subject but I want to focus this thread on the fork vs. push permissions discussion. |
@AArnott Thank you, I agree with granting access. Clearly I can not do maintenance by myself so I'm happy if this library can grow as OSS. My concern is about Unity. However, there are expectations that if a lot of people are concerned and properly discussed, it will be okay. |
I'm happy to support keeping Unity working. But yes, I'll be relying on you and anyone else more familiar with it than myself to act as guard rails for me. It sounds like before making "modernizing" changes that I should propose changes before making them since you can predict that some ideas are going to cause Unity complications from the outset. I've asked a question over at AArnott#9 to get the I'm glad you like the refactoring I've done so far. I'm doing it in the 'master' branch, after having branched off the code for v1.8 which won't have API breaking changes, but still has some of the other fixes I've been making. I'd also like to learn how you measure performance so I can do the same frequently as I'm coding up changes to make sure I'm not regressing any thing. Is your process for measuring documented anywhere? |
so seems no reason to hard fork now? |
Agreed, provided @neuecc follows up to grant me push permissions and/or review my PRs. |
@neuecc I haven't heard back from you on push permissions, nor seen any activity on my PRs. I'm now hitting merge conflicts when trying to update my fork with your changes since we haven't merged our codebases yet. Any update on when you intend to move forward with the merge plans? |
@AArnott Sorry, I've taken holidays(Christmas, new year). |
And access to the nuget |
Yes, sounds good. |
We run Unity 2018.3 targeting AOT with Memory well. I have hacked SignalR -> MessagePack via aspnet/SignalR#3122. Also SignalrR touches types of MessagePack which do Emit even not used Emited types later. So current API of MessagePack is not so Unity friendly.
For So as of now MessagePack does not plays nice with But with a bunch of hacks all works. |
@AArnott @dzmitry-lahoda |
See AArnott#1
The text was updated successfully, but these errors were encountered: