Add endpoints for copying Mauro models and items #457
Assignees
Labels
enhancement
New feature or request
Comments
This was referenced May 7, 2024
mhocc
added a commit
that referenced
this issue
May 22, 2024
mhocc
added a commit
that referenced
this issue
May 23, 2024
- The test is not currently passing and this may be because the test
model is not valid.
- Worked around the security restriction in `DataModelInterceptor`—needs reviewing
- Noticed that copy permisssions is not implemented and will throw is
requested.
pjmonks
added a commit
that referenced
this issue
May 24, 2024
- Found issues with initial controller action, was not committing the copy to Mauro or setting model security correctly
- Moved controller action into ModelController for other model domains to use
- Changed URL to `PUT /dataModels/{id}/copy` to look consistent with fork endpoint
- Altered the PUT request body to not need branch name or version number. This will only work within a draft versioned folder, these will be inherited
- Updated test
pjmonks
added a commit
that referenced
this issue
May 24, 2024
- Ensure that new label selected is unique - Reorganise tests - Add additional tests to guarantee some of the edge cases - label uniqueness, source model exists, source model is not finalised
pjmonks
added a commit
that referenced
this issue
May 24, 2024
- Must be within a draft versioned folder - Must be copied to the same versioned folder (but can be in a different sub-folder) - Update tests to check all conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Mauro has some abilities to copy catalogue items, yet it does not provide enough public HTTP endpoints to carry these operations out. These need to be included to support the copying of items - this will make it easier to create new items based on more complex items which already contain a lot of information.
The following domain types must be supported:
Note: Data Classes and Data Elements are also required to fulfil a use case, but endpoints already exist for these types.
Scope
The copy actions should only be allowed for models or sub-items which are within a draft versioned folder. It would not make sense for a model to be allowed to be copied in a finalised versioned folder - this can just be forked. This copy action represents a user wanting to copy an existing catalogue item to base on and then modify.
URL Mappings and Services
Each item service e.g.
DataModelServicealready has acopyModel()method (or similar), they just need to be mapped to controllers and endpoints.The interceptors of each controller should be modified so that if a copy operation is requested, check that the current user is allowed to edit the target model/item and read the source model/item.
Available Actions
The
UserSecurityPolicyManagercontains methods to fetch the available actions allowed for an item. Thecopyaction should be included in this list as appropriate. This will assist the frontend for deciding which options are shown to the user.copyshould only be allowed when a model (or sub-item) is within a draft versioned folder.Asynchronous action
Compared to a new fork, Mauro should allow a copy to be asynchronous if requested as a parameter.
The text was updated successfully, but these errors were encountered: