Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.10 in CI and bump GH actions #82

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

JPBergsma
Copy link
Contributor

As we are dropping support for python 3.7 in the optimade python tools, I think we should drop it here too.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying required tweak that stops the build failing. We could also update all of the Github Actions versions in this PR (e.g., checkout@v3). I don't think I want to enable dependabot on this repo as it becomes very noisy.

.github/workflows/python_validate.yml Outdated Show resolved Hide resolved
@@ -12,7 +12,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/setup-python@v2
uses: actions/setup-python@v4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have updated the github actions as well.

JPBergsma and others added 2 commits July 19, 2022 12:37
Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
@JPBergsma JPBergsma requested a review from ml-evs July 19, 2022 10:44
@ml-evs ml-evs changed the title Use python 3.10 instead of 3.7 in python_validate.yml Use Python 3.10 in CI and bump GH actions Jul 19, 2022
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JPBergsma!

@JPBergsma JPBergsma merged commit d2493aa into master Jul 19, 2022
@JPBergsma JPBergsma deleted the JPBergsma-drop-python-3.7 branch July 19, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants