Add CCP-NC Database #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merkys
previously approved these changes
Apr 12, 2022
ml-evs
commented
Jul 7, 2022
|
Has this PR been sitting here since April? Sorry about that. Merge your 'cod' -> 'ccpnc' edit and I will approve. |
It has, but only because I've also been unable to do the underlying database work yet, so its not a problem! |
|
Just had a meeting about this and its going to be a while until the base URL listed here goes live, so I will set it to EDIT: I've done this at the child database level, not sure if anyone is doing it this way but I think it's allowed, probably a good test for clients... |
ml-evs
commented
Jul 7, 2022
ml-evs
commented
Jul 7, 2022
ml-evs
commented
Jul 7, 2022
rartino
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the upcoming OPTIMADE API for the CCP-NC Database being implemented by @jkshenton and myself.
I also had to add a sleep to the CI so that validation only runs after netlify has sorted itself out.