Redirect static base URLs to a helpful landing page #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work, try e.g. https://deploy-preview-77--optimade-providers.netlify.app/index-metadbs/tcod/ |
ml-evs
changed the title
ml-evs
force-pushed
the
ml-evs/add_redirects
branch
from
11817ff
to
19ba0a0
Compare
ml-evs
force-pushed
the
ml-evs/add_redirects
branch
from
19ba0a0
to
7f30e5f
Compare
|
Think this is ready @CasperWA! |
ml-evs
commented
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a potential solution for #76, by redirecting the static base URLs served here to a semi-informative landing page, rather than 404'ing.
Unfortunately netlify can't do redirects based on
Acceptheaders, so serving a JSON response is not possible (unless we get rid of this HTML response). The HTML response mimics the way most providers are handling their base URLs, so I don't think there is an issue here.