Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details and static index meta-db for JARVIS #72

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 8, 2021

This PR adds a static index meta-db for JARVIS and links out to the JARVIS-DFT database, which is now publicly available via OPTIMADE.

@knc6: I took the description from your website at https://www.nist.gov/programs-projects/jarvis-dft, please let me know if you want it to say something different.

@knc6
Copy link
Contributor

knc6 commented Sep 8, 2021

Thank you, @ml-evs
Should we change base_url in links.json,

"base_url": "https://jarvis.nist.gov/optimade/jarvisdft",
to https://jarvis.nist.gov/optimade/jarvisdft/v1 i.e. the link with '/v1' at the end ?

@ml-evs
Copy link
Member Author

ml-evs commented Sep 8, 2021

Thank you, @ml-evs
Should we change base_url in links.json,

"base_url": "https://jarvis.nist.gov/optimade/jarvisdft",
to https://jarvis.nist.gov/optimade/jarvisdft/v1 i.e. the link with '/v1' at the end ?

No, the base URL should omit the version, clients will automatically add it.

@knc6
Copy link
Contributor

knc6 commented Sep 8, 2021

Thank you, @ml-evs
Should we change base_url in links.json,

"base_url": "https://jarvis.nist.gov/optimade/jarvisdft",

to https://jarvis.nist.gov/optimade/jarvisdft/v1 i.e. the link with '/v1' at the end ?

No, the base URL should omit the version, clients will automatically add it.

Sounds good.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

src/index-metadbs/jarvis/v1/info.json Show resolved Hide resolved
@ml-evs ml-evs merged commit 368f9f6 into master Sep 8, 2021
@ml-evs ml-evs deleted the ml-evs/update_jarvis branch September 8, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants