Add AFLOW to providers lists #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperWA
reviewed
Jan 6, 2021
There was a problem hiding this comment.
I don't see any issues.
However, do you not want to add a short description about AFLOW in the providers.json? It will be used in clients and such.
Also, your OPTIMADE database endpoint http://aflow.org/API/optimade/ seems to not supply entry listing or introspective endpoints. But I guess this is fine for now of course.
ml-evs
reviewed
Jan 6, 2021
|
I've added a description of AFLOW to the providers.json, and changed http to https, as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the directory providers/src/index-metadbs/aflow with info.json and links.json files. Also modifies the providers.json file in accordance with the instructions in the README.