-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for /versions endpoint #54
Add support for /versions endpoint #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me, especially with the latest testing 👍 Thanks @rartino !
I am wondering whether we need to also add support for the api_version
query parameter? (If that's what it's called, can't remember now.)
I hope not, but we should check in the specification and fix it there if it says so, I guess?
Otherwise, I think you can merge-at-will :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment from me, the version negotiation for this repo doesn't work according to the specification, which dictates that 553 Version Not Supported must be returned when requesting e.g. http://deploy-preview-54--optimade-providers.netlify.app/v2 ... other than that, everything looks fine on the deploy preview!
Perhaps the validator could be run in the CI for this repo, or somewhere else?
and similarly for the hosted dbs:
|
Support for /versions is on MUST level. After this PR, according to my reading, we only break SHOULD level requirements, rights? @CasperWA So, trying to decipher exactly what we've written about @ml-evs Indeed, the failure to return 553 on |
I thought that was what the "Scheduled validator / OPTIMADE validator" did? But maybe I'm wrong? :) |
That seems to be running some more manual tests that just check for deserialization (which is fine)... using the actual validator can definitely wait :) |
The index meta-database isn't exempt from the mandatory /versions endpoint in the OPTIMADE specification v1.0.0 section 5.2 (right?).
This PR adds this support when hosing via netlify.
Edit: Realized we need the same support also for the hosted index meta-databases. I think I've added it
(but it isn't yet tested - I'll check the netlify deploy as soon as it is finished).-- yes, it now seems to work in the netlify deploy.