Adding OQMD's info to providers.json #52
Conversation
|
Hi @tachyontraveler, nice job getting the API up and running! It looks like there's just a couple of minor technical things going wrong.
$ curl http://oqmd.org/optimade/v1/info
<body>
<pre>
{
"meta": {
"api_version": "1.0.0",
"query": {
"representation": "/info"
},
"more_data_available": false,
"schema": "https://schemas.optimade.org/openapi/v1.0/optimade_index.json"
... |
src/links/v1/providers.json
Outdated
| "homepage": null, | ||
| "name": "The Open Quantum Materials Database", | ||
| "description": "The OQMD is a database of DFT calculated thermodynamic and structural properties of materials", | ||
| "base_url": "http://oqmd.org/optimade", |
There was a problem hiding this comment.
This would be the only change required in the providers file, you would then need to add an oqmd/ folder that follows the same structure as e.g. https://github.com/Materials-Consortia/providers/tree/master/src/index-metadbs/mp/v1
| "base_url": "http://oqmd.org/optimade", | |
| "base_url": "http://providers.optimade.org/index-metadbs/oqmd", |
There was a problem hiding this comment.
It looks like this PR still hasn't made it in, but the instructions are all there if you wanted to self-host #18 or here https://github.com/Materials-Consortia/providers/tree/master/src/index-metadbs if you wanted to use this repo
There was a problem hiding this comment.
It looks like this PR still hasn't made it in, but the instructions are all there if you wanted to self-host #18 or here https://github.com/Materials-Consortia/providers/tree/master/src/index-metadbs if you wanted to use this repo
I have just merged this now. So you can read the instructions directly in the repository README on the landing page.
There was a problem hiding this comment.
LGTM, thanks @tachyontraveler!
There's a couple of things that the optimade-validator is stumbling over when I run it on http://oqmd.org/optimade locally. Is the qmpy repository the appropriate place to raise any issues if need be?
|
@ml-evs Thanks for looking into validation issues. It'd be great if you can raise an issue here at https://github.com/wolverton-research-group/qmpy/issues . I will merge this PR in the meantime since any fixes to such issues will not affect scripts on any files involved in this PR. |
OPTiMaDe v1.0.0 is now fully incorporated into
qmpy(Django-based Python API that OQMD is based on).I can pull the new scripts onto the public
oqmd.orgwebsite once the internal review ofqmpyis finished, but the final base-URLs are now designated.I will update it here when the
optimade-validatorcan accessoqmd.org/optimadefor validation. Created this PR now to initiate the process.