Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard is implicitly validating against v1.1 #52

Open
ml-evs opened this issue Jul 7, 2021 · 2 comments
Open

Dashboard is implicitly validating against v1.1 #52

ml-evs opened this issue Jul 7, 2021 · 2 comments

Comments

@ml-evs
Copy link
Member

ml-evs commented Jul 7, 2021

This is fine for now, as v1.1 only made minor changes that do not break validation, but we should consider for future versions what the dashboard should actually show. It may be that the validator should start selecting the appropriate version that the implementation reports, though this would require a series of changes in optimade-python-tools.

cc @CasperWA

@CasperWA
Copy link
Member

CasperWA commented Jul 7, 2021

Maybe we only focus on v1? But.. well, one might want to know all the various versions supported by an implementation? Although, I as implementer will only ever keep one supported version - unless some drastic change occurs (read: a major version change).

@rartino
Copy link
Contributor

rartino commented Jul 7, 2021

Note the question in: Materials-Consortia/OPTIMADE#366 (comment)

If our interpretation of semantic versioning means that an implementation that validates in v1.x always must validate in v1.y, y>x, then indeed the validator only needs to validate the latest v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants