Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile to fix ip binary issue #71

Merged
merged 3 commits into from
Aug 20, 2021
Merged

Update Dockerfile to fix ip binary issue #71

merged 3 commits into from
Aug 20, 2021

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Aug 20, 2021 •
edited

Fixes #70.

  • Add pipefail command to Dockerfile.
  • Set specific docker image and install minimum dependencies.

@CasperWA CasperWA marked this pull request as draft August 20, 2021 11:15
@CasperWA CasperWA requested a review from ml-evs August 20, 2021 11:15
ml-evs
ml-evs reviewed Aug 20, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@CasperWA CasperWA marked this pull request as ready for review August 20, 2021 11:40
@CasperWA CasperWA requested a review from ml-evs August 20, 2021 11:44
ml-evs
ml-evs approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CasperWA!

@ml-evs ml-evs merged commit 071c7af into master Aug 20, 2021
@ml-evs ml-evs deleted the fix_70_ip-not-accessible branch August 20, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default gh_actions_host domain is no longer valid?
2 participants
@CasperWA @ml-evs