Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/sources: improve rehydration time for upsert sources #26003

Closed
morsapaes opened this issue Mar 13, 2024 · 0 comments · Fixed by #27064
Closed

storage/sources: improve rehydration time for upsert sources #26003

morsapaes opened this issue Mar 13, 2024 · 0 comments · Fixed by #27064
Assignees
Labels
A-STORAGE Topics related to the Storage layer C-feature Category: new feature or request

Comments

@morsapaes
Copy link
Contributor

morsapaes commented Mar 13, 2024

@guswynn had penciled down potential optimizations to our spill-to-disk implementation. Now that we have additional disk space on replicas, a quick win to improve rehydration times of upsert sources would be to use RocksDB's native merge operator. This would make rehydration a pure write workload, rather than a read-then-write, and allow us to trade-off CPU for speed.

In the future, we might reconsider using RocksDB. See this Slack thread for initial benchmarks of rehydration performance for upsert sources using different state backends.

Action log

  • 15 March 2024. Set release date as April 19 with medium confidence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-STORAGE Topics related to the Storage layer C-feature Category: new feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants