Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docs on pre-release comparator handling #71

Merged
merged 2 commits into from Apr 10, 2018

Conversation

mattfarina
Copy link
Member

There has been confusion on the use of pre-releases in comparison
ranges. This attempts to add more detail to help end users
figure them out.

There has been confusion on the use of pre-releases in comparison
ranges. This attempts to add more detail to help end users
figure them out.
Copy link

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattfarina it looks great to me - perhaps you could add a clarification about the meaning of a pre-release?

README.md Outdated

> _A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version._
According to the Semantic Version specification pre-releases may not be

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially arrived to the semver repo without a clear conception of what a pre-release was, perhaps you could help the former me by adding a small parenthesis clarification.

According to the Semantic Version specification pre-releases (-alpha, -beta etc.) may not be API compliant with their release counterpart. It says,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree -- a quick mention might help. I'd consider it a non-blocker, though. Otherwise, this looks great.

README.md Outdated

> _A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version._
According to the Semantic Version specification pre-releases may not be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree -- a quick mention might help. I'd consider it a non-blocker, though. Otherwise, this looks great.

@mattfarina mattfarina merged commit 9212b0d into master Apr 10, 2018
@mattfarina mattfarina deleted the docs/engage-pre branch April 10, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants