Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20221209-update-renovatejson-v4 tag does not fail NewVersion test #193

Open
bcbrockway opened this issue Dec 19, 2022 · 2 comments
Open

20221209-update-renovatejson-v4 tag does not fail NewVersion test #193

bcbrockway opened this issue Dec 19, 2022 · 2 comments
Labels
question

Comments

@bcbrockway
Copy link

Hi all, our ArgoCD Image Updater randomly changed one of our prod tags from v1.10.0 to a branch image - 20221209-update-renovatejson-v4. They use the NewVersion function (here) and we should probably petition them to add an option to use StrictNewVersion but should NewVersion really be accepting that tag as a valid semver?
@bcbrockway bcbrockway changed the title 20221209-update-renovatejson-v4 tag does not fail NewVersion test 20221209-update-renovatejson-v4 tag does not fail NewVersion test Dec 19, 2022
@bcbrockway bcbrockway mentioned this issue Dec 19, 2022
Open
@mattfarina mattfarina added the bug label Feb 23, 2023
@mattfarina
Copy link
Member

@bcbrockway it looks like you found a bug.

@mattfarina mattfarina added question and removed bug labels Apr 3, 2023
@mattfarina
Copy link
Member

It turns out I was wrong. From the spec:

Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]

If you read the grammar you'll find the - explicitly listed for the <non-digit> cases.

A - is allowed. So, NewVersion should parse 20221209-update-renovatejson-v4 as valid while StrictNewVersion should provide an error.

@mattfarina mattfarina mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattfarina @bcbrockway