Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub Actions #139

Merged
merged 1 commit into from Dec 8, 2019
Merged

Switch to GitHub Actions #139

merged 1 commit into from Dec 8, 2019

Conversation

mattfarina
Copy link
Member

@mattfarina mattfarina commented Dec 7, 2019 •
edited

  • GitHub Actions are setup to run for Mac, Linux, and Windows
  • Linting only happens on Linux as we don't need to repeat this and it is complicated to install on both POSIX and window systems easily
  • In the doc.go file the word build was modified to b because the go toolchain on Windows (only windows) was considering the comment to be a malformed build comment. It was misdetecting it.
  • Travis and Appveyor configuration have been removed

@mattfarina mattfarina force-pushed the add-actions branch 7 times, most recently from 1db14a7 to c90f735 Compare December 7, 2019 20:40
@mattfarina
Migrating to GitHub Actions for CI
a1ba742 
* GitHub Actions are setup to run for Mac, Linux, and Windows
* Linting only happens on Linux as we don't need to repeat this
  and it is complicated to install on both POSIX and windows
  systems easily
* In the doc.go file the word build was modified to b because the
  go toolchain on Windows (only windows) was considering the comment
  to be a malformed build comment. It was misdetecting it.
* Travis and Appveyor configuration have been removed
@mattfarina mattfarina changed the title Adding github actions Switch to GitHub Actions Dec 7, 2019
@mattfarina
Copy link
Member Author

The output of this run can be found at https://github.com/mattfarina/semver/commit/a1ba742bccb6101d4ffabeca93cc2888a3bc2aa7/checks?check_suite_id=347260585

technosophos
technosophos approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mattfarina mattfarina merged commit 8d40cdf into Masterminds:master Dec 8, 2019
@mattfarina mattfarina deleted the add-actions branch December 8, 2019 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technosophos technosophos technosophos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattfarina @technosophos