Remove deprecation warning from waitress

[girardinsamuel]

There is a deprecation warning that we can get rid of by explicitly do:

# ServeCommand.py

# ...
waitress.serve(application, host=host, port=port, clear_untrusted_proxy_headers=True)

In the future this parameter will be automatically set to True. So I was thinking to set this to True now but doc below confuses me. It seems that we should also provided trusted_proxy parameter ?

More info here https://docs.pylonsproject.org/projects/waitress/en/stable/arguments.html

[josephmancuso]

I added this but still getting the deprecation warning .. is it just a warning we always see? 🤔

[girardinsamuel]

I will check into the third party code and update PR if required. Maybe it will be there until release...

[josephmancuso]

That's what I'm thinking

[josephmancuso]

I don't think we can get rid of this for now unfortunately. We'll have to monitor for a new release

[girardinsamuel]

Yep ! This might be solved in upcoming 2.0
Pylons/waitress#330