Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct file perms on nested snapshot dir #108

Merged
merged 2 commits into from Apr 5, 2022

Conversation

jamestelfer
Copy link
Contributor

@jamestelfer jamestelfer commented Apr 5, 2022

When the test name contains a path separator, make sure the directories are created with the correct permissions.

Fixes #107

Depends on #109 to fix the linting check failure.

When the test name contains a path separator, make sure the directories
are created with the correct permissions.
@github-actions github-actions bot added the fix label Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #108 (30a2497) into main (5f89bc5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          10       10           
  Lines         658      658           
=======================================
  Hits          581      581           
  Misses         40       40           
  Partials       37       37           
Impacted Files Coverage Δ
snapshot.go 83.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f89bc5...30a2497. Read the comment docs.

@github-actions github-actions bot added fix and removed fix labels Apr 5, 2022
Copy link
Owner

@MarvinJWendt MarvinJWendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing 🚀

@MarvinJWendt MarvinJWendt merged commit 105e940 into MarvinJWendt:main Apr 5, 2022
@MarvinJWendt
Copy link
Owner

Released in v0.3.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directories created with testza.SnapshotCreateOrValidate do not have execute permissions set
2 participants