test: add mobx to unit tests #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
changed the title
MarshallOfSound
approved these changes
Apr 7, 2020
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
facebook-github-bot
pushed a commit
to facebook/flipper
that referenced
this pull request
Apr 8, 2020
…ion � (#988) Summary: *** ☝️ **Important announcement:** Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! [Find out how to migrate to Snyk and more at greenkeeper.io](https://greenkeeper.io) *** ## The dependency [electron-devtools-installer](https://github.com/MarshallOfSound/electron-devtools-installer) was updated from `2.2.4` to `3.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- **Publisher:** [marshallofsound](https://www.npmjs.com/~marshallofsound) **License:** MIT <details> <summary>Release Notes for v3.0.0</summary> <h1><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/compare/v2.2.4...v3.0.0">3.0.0</a> (2020-04-07)</h1> <h3>Bug Fixes</h3> <ul> <li>make extension store directory recursively (<a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/82479523e251eb24e08d31aa52fbb06b913ac437">8247952</a>)</li> <li>only allow installs from the main process (<a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/fc1d8781b6280591b7d6c4913486d9863d2682d2">fc1d878</a>)</li> <li>support dynamic application path (<a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/issues/88" data-hovercard-type="pull_request" data-hovercard-url="/MarshallOfSound/electron-devtools-installer/pull/88/hovercard">https://github.com/facebook/flipper/issues/88</a>) (<a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/e9471f9042adf4070e446c9258c07925bb719f65">e9471f9</a>)</li> <li>use ES6 standard imports for electron modules. Closes <a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/issues/116" data-hovercard-type="pull_request" data-hovercard-url="/MarshallOfSound/electron-devtools-installer/pull/116/hovercard">https://github.com/facebook/flipper/issues/116</a> (<a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/dc0f6e4391cae930107716f610f14a3acb4ef347">dc0f6e4</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>test:</strong> add mobx to unit tests (<a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/issues/95" data-hovercard-type="pull_request" data-hovercard-url="/MarshallOfSound/electron-devtools-installer/pull/95/hovercard">https://github.com/facebook/flipper/issues/95</a>) (<a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/6d4f699877c97ec5a91914180434d8d3175951d8">6d4f699</a>)</li> <li>Only allow installs from the main process (<a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/d692149da53ef15d04b8c30e75f630f7f3cf0fd4">d692149</a>)</li> </ul> <h3>BREAKING CHANGES</h3> <ul> <li>Only allow installs from the main process</li> </ul> <p>The remote is being deprecated and as such we should not rely on it for what is a buggy and very small usability tweak.</p> </details> <details> <summary>Commits</summary> <p>The new version differs by 22 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/d692149da53ef15d04b8c30e75f630f7f3cf0fd4"><code>d692149</code></a> <code>feat: Only allow installs from the main process</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/0f3ebfc9d3744834bf539d0dd16cb47033204326"><code>0f3ebfc</code></a> <code>chore: update NPM readme badge</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/ba9648c2b91cede408fbf9ece20c3a1ec8d27e4d"><code>ba9648c</code></a> <code>chore: update README badges</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/776912cf7d9ec11981e1d726fa5b4b167506352f"><code>776912c</code></a> <code>BREAKING CHANGE: Only allow installs from the main process</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/ae075d13bc9c92246522e01666c42407b4ec2de0"><code>ae075d1</code></a> <code>build: update CFA plugin</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/0dde83b4a775f1cb44d43770a01d084efd7b124d"><code>0dde83b</code></a> <code>build: use latest v10 node for release CI</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/cc8700c784d06a5184ff95ec969cfb2847c8dda5"><code>cc8700c</code></a> <code>build: update version number for CFA</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/9628782f2f4f540524fb2e626a95e6b113e897e8"><code>9628782</code></a> <code>build: add CFA</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/7d5f15793915f92ac113e79aafb1f6c2d7afe190"><code>7d5f157</code></a> <code>docs: clean up README</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/6d4f699877c97ec5a91914180434d8d3175951d8"><code>6d4f699</code></a> <code>feat(test): add mobx to unit tests (https://github.com/facebook/flipper/issues/95)</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/dc0f6e4391cae930107716f610f14a3acb4ef347"><code>dc0f6e4</code></a> <code>fix: use ES6 standard imports for electron modules. Closes https://github.com/facebook/flipper/issues/116</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/82479523e251eb24e08d31aa52fbb06b913ac437"><code>8247952</code></a> <code>fix: make extension store directory recursively</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/fc1d8781b6280591b7d6c4913486d9863d2682d2"><code>fc1d878</code></a> <code>fix: only allow installs from the main process</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/a5dfe4c1b1c5441e0c07f7821676f29444c42642"><code>a5dfe4c</code></a> <code>build: rename prepublish to prepare, closes https://github.com/facebook/flipper/issues/120</code></li> <li><a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/commit/a5242e1fd8d7fc90d26d577e2c3b18a9703525ce"><code>a5242e1</code></a> <code>build: update dependencies</code></li> </ul> <p>There are 22 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/MarshallOfSound/electron-devtools-installer/compare/0b07982a063079aa12ffc34c12c202e7061c0a62...d692149da53ef15d04b8c30e75f630f7f3cf0fd4">full diff</a></p> </details> --- <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Pull Request resolved: #988 Test Plan: {F233368502} Tested in Flipper Reviewed By: cekkaewnumchai Differential Revision: D20889307 Pulled By: passy fbshipit-source-id: 63ed886cceefe34dc7d4212f25d05c5e13f7dab8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.