Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially misleading behavior of shoudNotThrow #217

Open
piotrb5e3 opened this issue Oct 14, 2022 · 0 comments
Open

Potentially misleading behavior of shoudNotThrow #217

piotrb5e3 opened this issue Oct 14, 2022 · 0 comments

Comments

@piotrb5e3
Copy link
Contributor

I think shouldNotThrow could hide a programming error.

The following code completes without issues:

invoking { throw IllegalArgumentException() } shouldNotThrow CustomException::class

I think the IllegalArgumentException should be re-thrown so it's not hidden from the developer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@piotrb5e3