Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare_output() fails on Windows due to different line endings #154

Open
fkohlgrueber opened this issue Jan 11, 2019 · 1 comment
Open

Comments

@fkohlgrueber
Copy link

I described the issue in rust-lang/rust before (link).

As noted in that issue, all one needs to do is to create a .gitattributes that forces LF line endings on checkout.

Do you agree that a .gitattributes file should be added to this repo? It might also be a good idea to make this information part of the docs.

I can open a PR if you want me to.

@laumann
Copy link
Collaborator

laumann commented Mar 12, 2019

Hi @fkohlgrueber I totally missed this issue being posted, I'm sorry!

Do you agree that a .gitattributes file should be added to this repo? It might also be a good idea to make this information part of the docs.

If that's all it takes to fix it, I have no problem with it, but I don't really have a good way of testing it myself.

I can open a PR if you want me to.

Please do :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants