Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test warnings #107

Merged
merged 1 commit into from Jun 30, 2019
Merged

Fix test warnings #107

merged 1 commit into from Jun 30, 2019

Conversation

npras
Copy link
Contributor

@npras npras commented Jun 20, 2019

There were warnings when running rake.
This fixes them.

The warnings:

  1. DEPRECATED: Use assert_nil if expecting nil
  2. warning: method redefined; discarding old test_integer_formatting and warning: previous definition of test_integer_formatting was here

The fixes:

  • 1 was fixed by using the suggested assert_nil
  • 2 was fixed by suffixing the duplicate test with "_default"

@npras
Fix test warnings
36f983b 
The warnings:
1) "DEPRECATED: Use assert_nil if expecting nil"
2) warning: method redefined; discarding old test_integer_formatting,
warning: previous definition of test_integer_formatting was here

1) was fixed by using the suggested assert_nil
2) was fixed by suffixing the duplicate test with "_default"
@npras npras marked this pull request as ready for review June 20, 2019 17:38
@kbrock kbrock merged commit d1d8c60 into ManageIQ:master Jun 30, 2019
@kbrock
Copy link
Member

kbrock commented Jun 30, 2019

thank you @npras

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@npras @kbrock