Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better way to test posts with query params #269

Closed
imtayadeway opened this issue Jan 9, 2018 · 3 comments
Closed

Find a better way to test posts with query params #269

imtayadeway opened this issue Jan 9, 2018 · 3 comments
Labels

Comments

@imtayadeway
Copy link
Contributor

There's an open issue for this in rake-test: rack/rack-test#150. However, I don't see this moving ahead soon.

Alternatively, it may be better to respond to this test pain by figuring out a better way to implement this.

Links:

# TODO: provider_class in params, when supported (https://github.com/brynary/rack-test/issues/150)
post(api_providers_url + '?provider_class=provider', :params => gen_request(:create, sample_foreman))

# TODO: provider_class in params, when supported (https://github.com/brynary/rack-test/issues/150)
api_provider_custom_attributes_url(nil, generic_provider) + '?provider_class=provider'

imtayadeway added a commit to imtayadeway/manageiq-api that referenced this issue Jan 9, 2018
Since they have been converted into issues that we can track:

- ManageIQ#267
- ManageIQ#268
- ManageIQ#269
- ManageIQ#270
- ManageIQ#271
imtayadeway added a commit to imtayadeway/manageiq-api that referenced this issue May 3, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 16, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Jul 16, 2018
@JPrause
Copy link
Member

JPrause commented Jan 29, 2019

@gtanzillo @abellotti is this still a valid issue? If yes, please remove the stale label. If not can you close.
If there's no update by next week, I'll be closing this issue.

@JPrause
Copy link
Member

JPrause commented Feb 6, 2019

Closing issue. If you feel the issue needs to remain open, please either reopen or let me know and it will be reopened.
@miq-bot close_issue

@miq-bot miq-bot closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants