Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor create_only? for Base Saver #57

Open
agrare opened this issue Jan 2, 2019 · 3 comments
Open

Honor create_only? for Base Saver #57

agrare opened this issue Jan 2, 2019 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed size/s

Comments

@agrare
Copy link
Member

agrare commented Jan 2, 2019

--- a/lib/inventory_refresh/save_collection/saver/base.rb
+++ b/lib/inventory_refresh/save_collection/saver/base.rb
@@ -163,7 +163,7 @@ module InventoryRefresh::SaveCollection
               # Record was found in the DB but not sent for saving, that means it doesn't exist anymore and we should
               # delete it from the DB.
               delete_record!(record) if inventory_collection.delete_allowed?
-            else
+            elsif !inventory_collection.create_only?
               # Record was found in the DB and sent for saving, we will be updating the DB.
               update_record!(record, hash, inventory_object) if assert_referential_integrity(hash)

The create_only? option is honored by concurrent_safe_batch and batch save strategies but not by base.

@miq-bot miq-bot added the stale label Jul 15, 2019
@miq-bot
Copy link
Member

miq-bot commented Jul 15, 2019

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@mfeifer mfeifer added bug Something isn't working and removed stale labels Nov 14, 2019
@miq-bot miq-bot added the stale label Jun 11, 2020
@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2020

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

@agrare agrare removed the stale label Jul 6, 2020
@agrare agrare removed their assignment Sep 28, 2020
@agrare agrare added the help wanted Extra attention is needed label Sep 28, 2020
@agrare agrare added the size/s label Mar 30, 2021
@miq-bot miq-bot added the stale label Feb 27, 2023
@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy removed the stale label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed size/s
Projects
None yet
Development

No branches or pull requests

4 participants