[flutter_local_notifications] Add note about keeping @mipmap/ic_launcher resource
#1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Personally I'd rather the readme removed mentioning using the launcher icon but I reckon there'd be those in the community that would keep doing so that keeping it with what you added in the PR will minimise the number of issues opened on this |
mgonzalezc
pushed a commit
to developmentMindapps/flutter_local_notifications
that referenced
this pull request
Apr 12, 2023
…_flutter_local_notifications * commit '4b723e750d1371206520b10a122a444c4bba7475': (76 commits) [flutter_local_notifications] update docs on initialize method to describe callbacks more (MaikuB#1841) enable usePubspecOverrides with melos (MaikuB#1822) replaced placeholder.com with dummyimage.com in example app due to Cloudflare blocking requests (MaikuB#1821) Google Java Format [flutter_local_notifications] Fixes MaikuB#1486 :Adds ability to count down chronometer with chronometerCountDown (MaikuB#1778) Implement options to hide or crop attachments in the thumbnail on iOS (MaikuB#1785) bump linux plugin's Flutter version requirement to 3.0.0 and add explicit ffi dependency (MaikuB#1812) [flutter_local_notifications] re-add imports needed for Flutter 3.0 and add build tasks that use Flutter 3.0 (MaikuB#1811) updated example app to not request the ability to display critical alerts (MaikuB#1809) Add note about keeping `@mipmap/ic_launcher` resource (MaikuB#1804) Recommend WindowManager to fix Android 12L+ bugs (MaikuB#1803) [flutter_local_notifications] Upgraded Android Gradle Plugin to fix Android build (MaikuB#1781) [flutter_local_notifications] fixes parsing of callback handles for notification actions on Android (MaikuB#1798) [flutter_local_notifications] fix Kotlin version used in example app (MaikuB#1791) Updates readme for iOS Setup (MaikuB#1776) added missing kudos for contributions relating to flutter_local_notifications 12.0.3 release release flutter_local_notifications 12.0.3 updated code snippet in readme on requesting permissions on Android (MaikuB#1754) Google Java Format Drop registerWith in Android plugin (MaikuB#1745) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note to prevent issues like #1762.
I agree with @MaikuB 's sentiment that there are multiple ways to configure things and this is app specific configuration, however, the README does slightly nudge you in this direction if you're just trying to get things working. It does note that it isn't recommended, but it's not clear what the consequences will be.
Alternatively, removing the note about it being possible to use
ic_launcherand provide much stronger recommendations against it instead might be another approach to avoid this.