Replace as *... raw pointer-type changes with more explicit .cast()
#685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.cast()` allows changing the pointer type without hiding (accidental) mutability changes (noting that `*mut` still coerces to `*.const`). For mutability changes Rust 1.65 included `cast_mut()` and `cast_const()`, but those would bump our MSRV too eagerly for now.
Ralith
approved these changes
Nov 22, 2022
MarijnS95
added a commit
that referenced
this pull request
Nov 22, 2022
…)` (#685) `.cast()` allows changing the pointer type without hiding (accidental) mutability changes (noting that `*mut` still coerces to `*.const`). For mutability changes Rust 1.65 included `cast_mut()` and `cast_const()`, but those would bump our MSRV too eagerly for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.cast()allows changing the pointer type without hiding (accidental) mutability changes (noting that*mutstill coerces to*.const).For mutability changes Rust 1.65 included
cast_mut()andcast_const(), but those would bump our MSRV too eagerly for now.