Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vulkan-Headers to 1.3.235 #667

Merged
merged 7 commits into from Nov 22, 2022
Merged

Update Vulkan-Headers to 1.3.235 #667

merged 7 commits into from Nov 22, 2022

Conversation

MarijnS95
Copy link
Collaborator

@MarijnS95 MarijnS95 commented Sep 29, 2022 •
edited

Depends on #666

@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.3.230 Update Vulkan-Headers to 1.3.231 Oct 17, 2022
This was referenced Oct 17, 2022
Open
Merged
@MarijnS95 MarijnS95 changed the title Update Vulkan-Headers to 1.3.231 Update Vulkan-Headers to 1.3.235 Nov 17, 2022
This was referenced Nov 18, 2022
Merged
Closed
@MarijnS95 MarijnS95 linked an issue Nov 18, 2022 that may be closed by this pull request
Missing dynamic state enum variants #680
Closed
Ralith
Ralith approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved conditional on confirmation that the video extensions are still intended to be semver-exempt (do we document this anywhere?).

@MarijnS95
Copy link
Collaborator Author

Yeah, it's semver-exempt but looks like we (I 👀) didn't even document it anywhere outside of #417, not even in the README...

@Ralith
Copy link
Collaborator

Ralith commented Nov 21, 2022

Bonus points for adding docs and even a feature gate, then.

@MarijnS95
Copy link
Collaborator Author

@Ralith Done in README.md! Conciseness isn't really my thing, feel free to suggest improvements.

While at it, maybe we should soup-up our module docs as well 😅

@MarijnS95
Copy link
Collaborator Author

Rebased on GH and of course, needed some manual attention to integrate cleaned-up casts from #685.

@MarijnS95 MarijnS95 merged commit ba37cf3 into ash-rs:master Nov 22, 2022
@MarijnS95 MarijnS95 deleted the update branch November 22, 2022 22:13
MarijnS95 added a commit that referenced this pull request Nov 22, 2022
@MarijnS95
Update Vulkan-Headers to 1.3.235 (#667)
47ec56c 
* Update Vulkan-Headers to 1.3.229

* Update Vulkan-Headers to 1.3.230

* Update Vulkan-Headers to 1.3.231

* Update Vulkan-Headers to 1.3.232

* Update Vulkan-Headers to 1.3.233

* Update Vulkan-Headers to 1.3.235

* README: Document experimental Vulkan Video bindings being semver-exempt
@MarijnS95 MarijnS95 mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dynamic state enum variants
2 participants
@MarijnS95 @Ralith