ash-window: Upgrade to raw-window-handle 0.5.0 #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Jul 28, 2022
|
We'll have to wait some for rust-windowing/winit#2400 to back out of the 1.60 MSRV change. |
msiglreith
reviewed
Jul 29, 2022
MarijnS95
force-pushed
the
rwh-0.5
branch
2 times, most recently
from
fc1aabf
to
a484fbd
Compare
jo12bar
added a commit
to jo12bar/vulkan-tutorial-rs
that referenced
this pull request
Aug 15, 2022
Also downgrade winit to fix version compatibility of raw-window-handle with ash-window. This can be undone once ash-rs/ash#645 is merged.
MarijnS95
force-pushed
the
rwh-0.5
branch
2 times, most recently
from
2779d6c
to
89d0ccb
Compare
MarijnS95
requested review from
msiglreith,
kchibisov and
Ralith
and removed request for
msiglreith and
kchibisov
msiglreith
approved these changes
Sep 19, 2022
Ralith
reviewed
Sep 19, 2022
…required_extensions()`
…le` _and_ `HasRawWindowHandle`
While the examples technically aren't part of our MSRV requirement (it's nice, but core crate compatibility is much more important), it's annoying to exempt these especially now that `winit` removed some unneeded MSRV 1.60/1.61 requirements.
Ralith
approved these changes
Sep 22, 2022
MarijnS95
added a commit
that referenced
this pull request
Sep 23, 2022
* ash-window: Upgrade to raw-window-handle 0.5.0 * Bump `raw-window-metal` to recently-released `0.3` norse-rs/raw-window-metal#5 * examples: Bump `winit` to `0.27.1` to resolve our MSRV tests While the examples technically aren't part of our MSRV requirement (it's nice, but core crate compatibility is much more important), it's annoying to exempt these especially now that `winit` removed some unneeded MSRV 1.60/1.61 requirements. * Take `Raw{Display,Window}Handle` directly instead of through trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #505, #643, norse-rs/raw-window-metal#5