New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new nodejs parser: llhttp #31
Comments
Hey @elprans ! Do you have an opinion about moving to |
We don't really have the bandwidth to make the switch, but if anyone wants to pick this up, patches are welcome! |
Hi @elprans ! I'm trying to take this one here: https://github.com/victoraugustolls/httptools I'm having some trouble with the tests due to some missing exceptions between The problem is that there are no callback errors for Maybe @indutny can help also? (sorry if tagging you here is wrong) |
@victoraugustolls I'd be happy to help! You basically need to do what Node.js does at this moment if you'd like to raise an error from the on_body/etc callbacks: llhttp_set_error_reason(&parser_, "HPE_JS_EXCEPTION:JS Exception");
return HPE_USER; |
Perfect! Thanks @indutny ! Will give it a go over the weekend! |
Is there any progress? |
Hey @abersheeran ! There is an open PR for it: #56 |
We've hit a delay with EdgeDB, but integrating httptools deeper in it is on my immediate todo. And so I'll be closely looking at that and will also likely release uvloop for 3.9. Sorry for the delay. |
Thanks to @victoraugustolls and everyone, this is done in #56. I'll get a release out soon. |
New node js parser: nodejs/http-parser#285 (comment)
The text was updated successfully, but these errors were encountered: