Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move postcss to peerDependencies #127

Closed
ilfa opened this issue Jun 9, 2020 · 4 comments
Closed

Move postcss to peerDependencies #127

ilfa opened this issue Jun 9, 2020 · 4 comments

Comments

@ilfa
Copy link

ilfa commented Jun 9, 2020

It will be great not to download extra version of postcss.

More details you can find in this article https://nodejs.org/en/blog/npm/peer-dependencies/.

I can create a PR if you are ok.

@ScottAwesome
Copy link

ScottAwesome commented Sep 17, 2020

@MadLittleMods since the move to postcss 8, in the Plugin BoilerPlate Repo they are showing postcss as a peerDependency.

edit: I found the migration guide, and it is now an official recommendation:

Official Migration Guide

@MadLittleMods
Copy link
Owner

Thanks for the context @ScottAwesome!

@ilfa Feel free to create a PR 👍

@MadLittleMods
Copy link
Owner

Fixed in #129 and shipped in postcss-css-variables@0.18.0 🚀

Thanks to @delucis for the contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants