-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Feat queue view export #2203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat queue view export #2203
Conversation
Thanks for the PR, I'll have a look soon! |
There's a doc change needed, see warning at the end of the page: https://docs.laravel-excel.com/3.1/exports/from-view.html If you can make that change to the docs, I can merge this feature. |
|
@zacksleo doc change looks fine, can you have a look at my inline comment about the extra test? |
OK, I will check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test. I would prefer to not have any duplication in regards to reading a view into the spreadsheet, can you check the inline comment. Thanks.
Thanks @zacksleo |
Requirements
Please take note of our contributing guidelines: https://laravel-excel-docs.dev/docs/3.0/getting-started/contributing
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Mark the following tasks as done:
Description of the Change
FromView is currently supported in combination with queues.
Why Should This Be Added?
ref #1795
Benefits
Possible Drawbacks
Verification Process
Applicable Issues