Skip to content

Feat queue view export #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 19, 2019
Merged

Conversation

zacksleo
Copy link
Contributor

@zacksleo zacksleo commented May 22, 2019

Requirements

Please take note of our contributing guidelines: https://laravel-excel-docs.dev/docs/3.0/getting-started/contributing
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Checked the pull requests to ensure that another person hasn't already submitted the feature or fix.
  • Adjusted the Documentation. Update from-view.md laravel-excel-docs#60
  • Added tests to ensure against regression.

Description of the Change

FromView is currently supported in combination with queues.

Why Should This Be Added?

ref #1795

Benefits

Possible Drawbacks

Verification Process

  1. Unit Test
  2. Manual Test

Applicable Issues

Sorry, something went wrong.

@zacksleo zacksleo changed the title WIP: Feat queue view export Feat queue view export May 23, 2019
@patrickbrouwers
Copy link
Member

Thanks for the PR, I'll have a look soon!

@patrickbrouwers
Copy link
Member

Adjusted the Documentation. (I think there is no need to update docs.)

There's a doc change needed, see warning at the end of the page: https://docs.laravel-excel.com/3.1/exports/from-view.html

If you can make that change to the docs, I can merge this feature.

@GlennM
Copy link
Contributor

GlennM commented Jun 18, 2019

If you can make that change to the docs, I can merge this feature.

SpartnerNL/laravel-excel-docs#60

@patrickbrouwers
Copy link
Member

@zacksleo doc change looks fine, can you have a look at my inline comment about the extra test?

@zacksleo
Copy link
Contributor Author

OK, I will check it.

Copy link
Member

@patrickbrouwers patrickbrouwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test. I would prefer to not have any duplication in regards to reading a view into the spreadsheet, can you check the inline comment. Thanks.

@patrickbrouwers patrickbrouwers merged commit 61bae48 into SpartnerNL:3.1 Jun 19, 2019
@patrickbrouwers
Copy link
Member

Thanks @zacksleo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants