Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mission] Nettoyage des propriétés isClosed et closedBy #1332

Closed
3 tasks done
claire2212 opened this issue Apr 19, 2024 · 0 comments · Fixed by #1389
Closed
3 tasks done

[Mission] Nettoyage des propriétés isClosed et closedBy #1332

claire2212 opened this issue Apr 19, 2024 · 0 comments · Fixed by #1389
Assignees
@claire2212
Labels
Synchro Mission tech. enhancement technical enhancement
Projects
Kanban

Comments

@claire2212
Copy link
Collaborator

claire2212 commented Apr 19, 2024 •
edited

Une fois que MonitorFish et RapportNav auront déployés le nouveau statut de mission on pourra :

  • Supprimer de l'api publique (input et outpout) les propriétés isClosed et closedBy
  • Dé-commenter le champ completedBy dans le test frontend/cypress/e2e/side_window/mission_form/main_form.spec.ts-> The mission form Should be updated When a mission update event is received'
  • Supprimer les champs completedBy, closedBy, isClosedde la constante MISSION_EVENT_UNSYNCHRONIZED_PROPERTIES_IN_FORM
@claire2212 claire2212 added the tech. enhancement technical enhancement label Apr 19, 2024
@claire2212 claire2212 self-assigned this Apr 19, 2024
@claire2212 claire2212 added this to Todo in Kanban Apr 19, 2024
@claire2212 claire2212 moved this from Todo to In progress in Kanban May 22, 2024
@claire2212 claire2212 mentioned this issue May 22, 2024
Merged
1 task
@claire2212 claire2212 moved this from In progress to In Code Review in Kanban May 22, 2024
claire2212 added a commit that referenced this issue May 24, 2024
@claire2212
[Tech] Suppression des propriétés closedBy et isClosed (#1389)
983c1ed 
## Related Pull Requests & Issues

- Resolve #1332

----

- [ ] Tests E2E (Cypress)
@claire2212 claire2212 moved this from In Code Review to To be deployed in INT for review in Kanban May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claire2212 claire2212

Labels
Synchro Mission tech. enhancement technical enhancement
Projects
Kanban
To be deployed in INT for review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tech] Suppression des propriétés closedBy et isClosed MTES-MCT/monitorenv
1 participant
@claire2212