Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoi d'un bilan contrôle hebdomadaire #1270

Closed
wants to merge 17 commits into from

Conversation

VincentAntoine
Copy link
Collaborator

@VincentAntoine VincentAntoine commented Mar 20, 2024

Copy link

gitguardian bot commented Mar 20, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9429425 Triggered Generic Password a0ac7ae datascience/.env.test View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ivangabriele
Copy link
Member

@VincentAntoine

  • J'ai renommé les props sur cette PR et j'ai rebased ensuite la mienne sur celle-là.
  • Dans le fichier de migration de création des colonnes, je serai pour switcher ensuite les colonnes en no default value (une fois créées avec le default value FALSE). C'est bien non-nullable sur ma PR.

D'ailleurs il vaudra peut-être mieux continuer ensemble sur ma PR, non ?

@ivangabriele
Copy link
Member

Incluse dans #1338.

@ivangabriele ivangabriele deleted the vincent/weekly_actions_email branch May 8, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants