Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to re-add render abandoned/cancelled marks #30

Open
taneliang opened this issue Jul 3, 2020 · 0 comments
Open

Attempt to re-add render abandoned/cancelled marks #30

taneliang opened this issue Jul 3, 2020 · 0 comments
Assignees
@taneliang
Projects
React Concurrent Mode Profiler

Comments

@taneliang
Copy link
Member

Following discussions with Brian at #11 (comment), we've removed markRenderAbandoned and its --render-cancel user timing mark as it could have false positives in certain situations. Brian suggests that we bring this up again once the main React PR is merged into React's main repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taneliang taneliang

Labels
None yet
Projects
No open projects
React Concurrent Mode Profiler
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taneliang