Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination not marked as nav #100

Closed
frrrances opened this issue Jan 12, 2017 · 3 comments
Closed

Pagination not marked as nav #100

frrrances opened this issue Jan 12, 2017 · 3 comments
Assignees
@frrrances

Comments

@frrrances
Copy link
Contributor

Wrap the pager buttons in a nav element or container with role="navigation" and label via aria-label="pager" or equivalent
@frrrances frrrances self-assigned this Jan 12, 2017
@frrrances
Copy link
Contributor Author

Fixed upstream on kaminari:
kaminari/kaminari#848

https://github.com/frrrances/kaminari/tree/add-a11y-roles

@frrrances
Copy link
Contributor Author

Merged! @JPrevost I'll leave this open until the gem is updated and we can change our source (we're still pointing to my forked copy.)

@JPrevost
Copy link
Member

This was resolved upstream and our Gemfile is using the official version so we're 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frrrances frrrances

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JPrevost @frrrances