Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark guessers with asv #4577

Open
lilyminium opened this issue Apr 24, 2024 · 2 comments
Open

Benchmark guessers with asv #4577

lilyminium opened this issue Apr 24, 2024 · 2 comments
Labels
benchmarks performance benchmarking with ASV

Comments

@lilyminium
Copy link
Member

We should benchmark the changes made in https://github.com/MDAnalysis/mdanalysis/pull/3753/files/a946156f440e0ec7714854723a201f4d4b941526#r1550099795 .
@lilyminium lilyminium added the benchmarks performance benchmarking with ASV label Apr 24, 2024
@lilyminium lilyminium mentioned this issue Apr 24, 2024
Open
4 tasks
@orbeckst
Copy link
Member

Is this issue a request to write new benchmarks or just a reminder to check the results for time_guessbonds before and after PR #3753 is merged in order to potentially address performance regressions?

@IAlibay
Copy link
Member

IAlibay commented Apr 24, 2024

Is this issue a request to write new benchmarks or just a reminder to check the results for time_guessbonds before and after PR #3753 is merged in order to potentially address performance regressions?

My initial comment was for checking - if it makes sense to do that is, iirc the PR updates a bit of the benchmark and it would be nice to be sure we aren't messing up anything, but also it's not crucial enough to hold the PR imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmarks performance benchmarking with ASV
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@orbeckst @IAlibay @lilyminium